These days, swim shorts should definitely be above your knee, but below where a reasonable pocket would end. The exact length is a matter of your height, leg length and your comfort/preference. Some guys like it a little shorter and others not so much. For pool and beach wear, midthigh or a little higher is the look for now.